Dynamically load available familyStyles #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessary to ensure that it re-renders when this.selectedFamily or this.selectedState changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the hardcoding of familyStyles
Up until now, each time Font Awesome releases a new familyStyle, it's been necessary to change the source code of this component to add the additional familyStyle.
With this PR, the set of available familyStyles for the active version of Font Awesome is retrieved from the GraphQL API.
Changing the UI
The above change also comes with a change of UI. There is no longer a filter button across the top row for each familyStyle to toggle its inclusion in the icon grid. Instead, there are two drop downs: Family and Style. Only the icons corresponding to the selected familyStyle are shown in the icon grid.
Duotone Custom Icons
Duotone custom icons are now working correctly.
Changing
QueryHandlerand queriesThe type signature for
QueryHandlerhas been changed to accept a second optional parameter:variables. This is to allow the use of GraphQL variables in queries.See also the Changelog.]]