Fix grid_proteus.py #231
Merged
Fix grid_proteus.py #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Now requires py>=3.11 for tomlkit
…s can cause problems for CALLIOPE and aren't realistic anyway
lsoucasse
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Thanks @nichollsh,
It is worth investing efforts in the grid tooling as it will probably be the main way to interact with the code in the future.
I saw you deleted two input config files. It is good to keep only a few of them.
| @@ -82,8 +78,13 @@ def __init__(self, *, config_path: Path | str) -> None: | |||
| # Loop counters | |||
| self.loops = None | |||
|
|
|||
| # Interior | |||
| self.IC_INTERIOR = -1 # initial condition | |||
There was a problem hiding this comment.
What is supposed to do this -1 value when passed to the interior models?
There was a problem hiding this comment.
This is a default value that is updated further down in the code. I set it to -1 to indicate that it's a default value.
|
Thanks @lsoucasse. I agree we should think carefully about the future work on grid_proteus - maybe this is something we can discuss in a meeting soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the grid functionality is broken because it expects the configuration file to be formatted as
key=value. This functionality is very useful, so I have made a quick patch to restore it. In the future we should explore #204 and #162 in more detail. I have also included some groundwork for approaching these, such as moving more variables into the Proteus class.I have written this in such a way that it depends on
tomlkit, which requires Python >= 3.11, meaning that PROTEUS now also requires Python>=3.11. Correspondingly, the tests now run for 3.11 and 3.13 rather than 3.10 and 3.12.Minor things: