Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between M_planet and M_interior #213

Closed
nichollsh opened this issue Oct 18, 2024 · 3 comments · Fixed by #214
Closed

Distinguish between M_planet and M_interior #213

nichollsh opened this issue Oct 18, 2024 · 3 comments · Fixed by #214
Assignees
Labels
enhancement New feature or request

Comments

@nichollsh
Copy link
Contributor

nichollsh commented Oct 18, 2024

Throughout the code we currently refer to the variable M_planet. However, in some cases this is used as the total planet mass, and in other cases as the mass of the interior (i.e. everything enclosed by the atmosphere-mantle interface).

We should use two variables to describe this: M_planet and M_int, where M_planet = M_int + M_atm, where M_int is the mass of the interior and M_atm is the mass of the atmosphere.

This is connected to #212, #50, #62, #82.

@nichollsh nichollsh added the enhancement New feature or request label Oct 18, 2024
@nichollsh nichollsh self-assigned this Oct 18, 2024
@nichollsh nichollsh moved this to In Progress in PROTEUS Development Roadmap Oct 18, 2024
@timlichtenberg
Copy link
Collaborator

Good point, and while doing this, we may want to separate it from M_core as well.

@nichollsh
Copy link
Contributor Author

Yeah that makes sense too. I'll make a PR for this once the current one is merged.

@nichollsh
Copy link
Contributor Author

nichollsh commented Oct 18, 2024

We will need to think about how to handle volatile mass partitioning. Should the mass of the interior decrease with outgassing? Do we provide SPIDER/ARAGOG with the dry or wet mantle mass? Or do we assume that volatile do not contribute to M_int? We could leave this for a next step.

If we do allow M_int to decrease with outgassing, then how does SPIDER handle that? Handling this properly will require a structure model, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants