Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left/right navigation to move between modules #288

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

wapgear
Copy link
Contributor

@wapgear wapgear commented Aug 15, 2019

When we have more than 5 modules (depends on the name size) we can't select it with mouse anymore.
So I think we can use left/right keys to switch between modules.

@wapgear
Copy link
Contributor Author

wapgear commented Aug 15, 2019

@parkerziegler WDYT?

@ryan-roemer
Copy link
Member

@parkerziegler -- I'm on board with this change and have kicked the tires. Any thoughts before I proceed?

@wapgear
Copy link
Contributor Author

wapgear commented Aug 29, 2019

@ryan-roemer any updates? :-)
If need to change anything I could do it on weekend

@ryan-roemer
Copy link
Member

@wapgear -- Thanks for checking in again! Can you catch this PR up to master and just kick the tires one last time with our example of yarn dev and make sure things work as expected...

Also, do you know how this deals with overflows (a la #268 Display overflows)? Would this PR fix that issue as well?

I think we may be able to close out #242 as well Unable to do pagination on the tabs when many chunk files are showing

Hopefully we can close out both of these issues with this PR!

@wapgear
Copy link
Contributor Author

wapgear commented Aug 29, 2019

@ryan-roemer Not sure about #268 but definitely it solves the #242 issue

Will update with master tomorrow and will test it! Thanks

@wapgear
Copy link
Contributor Author

wapgear commented Sep 7, 2019

@ryan-roemer I merged latest master changes and tested it - works just fine.
About issues #242 - yeah, this PR fix it
#268 - unfortunately (or maybe luckily) can't reproduce it on my projects

@ryan-roemer ryan-roemer merged commit d4d8e38 into FormidableLabs:master Sep 8, 2019
@ryan-roemer
Copy link
Member

Released in [email protected]

Thanks @wapgear ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants