Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor examples so we can support multiple per chart type #3017

Open
wants to merge 5 commits into
base: feat/theme-builder-docs-migration
Choose a base branch
from

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Dec 18, 2024

  • Migrates examples from config to examples
  • Change types to support multiple examples per chart type
  • Refactors the click outside handlers into a hook to support touch devices and other components
  • Adds a button for the preview options to make it more prominent

image

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 3098b3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Dec 20, 2024 7:35pm

@carbonrobot carbonrobot changed the base branch from main to feat/theme-builder-docs-migration December 18, 2024 19:22
@carbonrobot carbonrobot changed the title feat/theme examples Refactor examples so we can support multiple per chart type Dec 18, 2024
@ramenhog
Copy link
Contributor

@carbonrobot so I played around with a few layouts for the color palette panel and this is what I ended up with:

2024-12-20 14 19 27

It's still slightly unconventional UX 😅 but at least this way, the preview is always showing the user what the user is currently customizing and there's ways to go back and forth between seeing defaults and selected color scales.

Whatcha think? If you still prefer a dropdown up top and no radio buttons, we can do that. But when I had that layout, the number of controls felt more overwhelming and the user would have to go back up to adjust their preview color scale:

2024-12-20 14 41 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants