-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor examples so we can support multiple per chart type #3017
base: feat/theme-builder-docs-migration
Are you sure you want to change the base?
Refactor examples so we can support multiple per chart type #3017
Conversation
carbonrobot
commented
Dec 18, 2024
•
edited
Loading
edited
- Migrates examples from config to examples
- Change types to support multiple examples per chart type
- Refactors the click outside handlers into a hook to support touch devices and other components
- Adds a button for the preview options to make it more prominent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@carbonrobot so I played around with a few layouts for the color palette panel and this is what I ended up with: It's still slightly unconventional UX 😅 but at least this way, the preview is always showing the user what the user is currently customizing and there's ways to go back and forth between seeing defaults and selected color scales. Whatcha think? If you still prefer a dropdown up top and no radio buttons, we can do that. But when I had that layout, the number of controls felt more overwhelming and the user would have to go back up to adjust their preview color scale: |