Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in cursor rendering caused by #2999 #3001

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Dec 9, 2024

Correct the rendering regression caused by the change in #2999 and captured by Chromatic in https://www.chromatic.com/test?appId=5b4acf7c54c0490024d5980b&id=675360427f60e8728902e703 that caused the cursor to render outside the boundaries of the chart

Bug Render

image

Corrected Render

image

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Dec 9, 2024 2:35pm

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 3e08396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-cursor-container Patch
victory-create-container Patch
victory Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 386.04KB 386.04KB +0.01KB (+0.00%)
TOTAL +0.01KB

@carbonrobot carbonrobot merged commit eb1bbef into main Dec 9, 2024
7 checks passed
@carbonrobot carbonrobot deleted the fix/cursor-container branch December 9, 2024 15:45
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants