Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate path data to 2 decimal places #2996

Closed
wants to merge 1 commit into from

Conversation

cwagner22
Copy link

@cwagner22 cwagner22 commented Dec 4, 2024

Description

Fixes #2995

Edit: actually I had to use 3 decimal places

const formatPathData = (pathData) => {
  return pathData.replace(/\d+\.\d+/g, (match) => Math.round(parseFloat(match) * 1000) / 1000);
};

And patched victory-area (lib/area.js and esm/area.js)
(+ victory-line)

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: f8c55eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Dec 4, 2024 0:36am

@carbonrobot
Copy link
Contributor

Closing, as we will have to apply a global fix across all charts. More details in #2995

@carbonrobot carbonrobot closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VictoryArea path decinal places
2 participants