Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate demo project to its own pnpm workspace #2976

Closed
wants to merge 3 commits into from

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 18, 2024

Isolate demo project to its own pnpm workspace and fix the TS build errors.

  • Uses Vite as the demo server and hot reload
  • Moves all the dependencies to the new workspace and out of root
  • Updates all the imports to reference victory (this creates some duplicates, but we are eventually migrating all these files so this is ok for now)
  • Modifies the start command to separate running and package watch mode.
// start demo and watch demo files only
$ pnpm start

// start demo and watch packages and demo files
$ pnpm start:dev

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 18, 2024 8:50pm

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 28d39b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant