Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prettier formatting to run from root #2959

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 12, 2024

Modifies the build scripts so formatting must be run from root to leverage the parallel nature of newer versions of prettier. Also enables the --check flag so prettier will throw a non-zero exit code in CI and the build will fail when there are formatting issues.

New tooling such as eslint, jest, and prettier have support for running parallel across monorepos. The overhead of using both wireit parallel and the tools parallel increases the time to run by exhausting resources.

Also removes the format ci job, since formatting is included as part of ESLint's execution, so this was double-running.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 12, 2024 2:42pm

@carbonrobot carbonrobot changed the title chore/format prettier Refactor prettier formatting to run from root Nov 12, 2024
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 0c5496e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carbonrobot carbonrobot merged commit f0a2df9 into main Nov 12, 2024
7 checks passed
@carbonrobot carbonrobot deleted the chore/format-prettier branch November 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants