-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor prettier formatting to run from root #2959
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Modifies the build scripts so formatting must be run from root to leverage the parallel nature of newer versions of prettier. Also enables the
--check
flag so prettier will throw a non-zero exit code in CI and the build will fail when there are formatting issues.New tooling such as eslint, jest, and prettier have support for running parallel across monorepos. The overhead of using both wireit parallel and the tools parallel increases the time to run by exhausting resources.
Also removes the
format
ci job, since formatting is included as part of ESLint's execution, so this was double-running.