-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades ESLint to Version 9 #2958
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥👏 lgtm overall! Didn't see any obvious issues/errors when I played around with it locally either
Upgrades ESLint to Version 9 (Flat file config), and Prettier to latest. No runtime code was changed for this PR.
How to review
Due to the nature of linting tools, this is a massive PR and it is easier to review by looking at the atomic commits, in order:
1. Remove NPS as the eslint task runner commit: c0c935
We are migrating away from NPS as a task runner and this commit removes eslint from the NPS scripts and directly executes it from root. This allows ESLint to manage its own parallelism and execute significantly faster and with less resources.
2. Upgrade ESLint to Version 9 commit: f45fdc
FormidableLabs/eslint
since that is deprecatedeslint-plugin-import
which does not have a fully compatible ESLint9 version yet3. Resolve lint warnings in packages commit: 456a8
no-process-exit
,max-statements
,max-len
, andcomplexity
as providing low valuemax-nested-callbacks
now properly recognizes chained functions, so the disable comments have been removedreact/no-did-mount-set-state
is deprecated and no longer recommended@typescript-eslint/ban-types
is deprecated and has been replaced by@typescript-eslint/no-unsafe-functions
@typescript-eslint/no-empty-interface
is deprecated and has been replaced by@typescript-eslint/no-empty-object-type
@typescript-eslint/no-empty-function
is deprecated and no longer recommended4. Resolve lint warnings in demos commit: 47d34c
5. Resolve lint warnings in Storybook commit: 6f3f7a
6. Resolve lint warnings in build scripts commit: ed209b
7. Resolve lint warnings in website commit: 59503
8. Remove unneccessary files from wireit deps commit: 7d5d8