Split storybook stories into individual files

[carbonrobot]

Split storybook stories into individual files for easier maintenance and faster HMR. Improves the development experience by correct Types and Auto gen controls for props.

Previous format

// victory-area.stories.tsx
// cs2 format
export const Basic : () => 
...
export const Theme: () =>

New format

// victory-charts/victory-area/basic.stories.tsx
// cs3 format
export const Basic : { ...

// victory-charts/victory-area/theme.stories.tsx
// cs3 format
export const Theme: { ...

[changeset-bot]

⚠️ No Changeset found

Latest commit: 25ed241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
victory	✅ Ready (Inspect)	Visit Preview	Nov 7, 2024 9:25pm

[nlkluth]

Looks like a few places have control set to "string", but I think it should be "text"

[nlkluth]

Playing around a bit with the new file structure and everything seems good. I like it! 🎉

[ramenhog]

Also liking the new file structure! This makes it much easier to read and maintain.

Left a comment about a type error I noticed with control: "string". It looks like it's affecting the following files:

• stories/victory-charts/victory-animation/config.ts
• stories/victory-charts/victory-box-plot/config.ts
• stories/victory-charts/victory-candlestick/config.ts
• stories/victory-charts/victory-chart/config.ts

Also can confirm that the as const fixes those arg type errors for me ☝️

[carbonrobot]

Updated the types, fixed warnings, and corrected the VictoryLabel doc which listed props that were not actually defined on VictoryLabelProps.

[ramenhog]

Thanks for fixing! Everything looks generally good now.

I am still seeing a themeKey type issue for certain stories, but I really can't tell why it'd be an issue for one file and not the other. The configs and everything look correct. So it might just be my local 🤷‍♀️