You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a bundle-size difference analyzer to Victory so a PRs additions or subtractions from the end bundles size can be observed. Only measures the differences of packages/victory/dist/victory.min.js, but can be configured to measure individual package bundles as well. Uses nejcm/bundle-size-reporter-action for calculations.
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
I have included a changeset if this change will require a version change to one of the packages.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have run all builds, tests, and linting and all checks pass
I have added tests that prove my fix is effective or that my feature works
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a bundle-size difference analyzer to Victory so a PRs additions or subtractions from the end bundles size can be observed. Only measures the differences of
packages/victory/dist/victory.min.js
, but can be configured to measure individual package bundles as well. Uses nejcm/bundle-size-reporter-action for calculations.Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)