Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate storybook to typescript #2747

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Migrate storybook to typescript #2747

merged 4 commits into from
Jan 29, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 26, 2024

Migrate storybook to typescript and modern Component Story Format (CSF)

Note: Type checking of stories does not happen at compile time... yet. It is currently incompatible with our version of Babel+Monorepo. This will be enabled in a future PR.

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 3c01eb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 6:41pm

Copy link
Contributor

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🏆

@carbonrobot carbonrobot merged commit 3e7b21d into main Jan 29, 2024
13 checks passed
@carbonrobot carbonrobot deleted the ts-migrate/storybook branch January 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants