Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade storybook to v7 #2743

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Upgrade storybook to v7 #2743

merged 5 commits into from
Jan 25, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 25, 2024

Upgrades storybook to v7

  • Enables Node 18 for Storybook builds. Closes Upgrade Storybook and Webpack #2668
  • Adds the storybook linter for eslint
  • Migrates from the deprecated storiesOf syntax to Storybook Component Format for all stories in stories/containers-and-addons.js. This allows chromatic to also pick up these stories as new UX tests
  • Removes the conflicting chromatic build scripts from wireit so it does not interfere with the github build actions commands
  • Adds the wrapForPnp workaround for storybook globs in v7 to .storybook/main.js

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 6b582f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 3:49pm

@carbonrobot carbonrobot merged commit da87969 into main Jan 25, 2024
13 checks passed
@carbonrobot carbonrobot deleted the 2668-storybook-cleanup branch January 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Storybook and Webpack
2 participants