Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parallel builds in workflow for improved CI times #2705

Merged
merged 2 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,8 @@ on:
- main

jobs:
test:
name: Check Code
build:
runs-on: ubuntu-latest
env:
DISPLAY: :99.0
strategy:
matrix:
node-version: [16.x, 18.x]
Expand All @@ -34,5 +31,56 @@ jobs:
- name: Build libraries and distributions ${{ matrix.node-version }}
run: pnpm build

- name: Check Code ${{ matrix.node-version }}
run: pnpm check:ci
format:
needs: [build]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: 18.x

- name: Format
run: pnpm format

lint:
needs: [build]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: 18.x

- name: Lint
run: pnpm lint

types:
needs: [build]
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: ${{ matrix.node-version }}

- name: Types Check ${{ matrix.node-version }}
run: pnpm types:check

test:
needs: [build]
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: ${{ matrix.node-version }}

- name: Test ${{ matrix.node-version }}
run: pnpm jest
6 changes: 0 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@
"start": "concurrently --raw \"pnpm:build:lib:esm --watch\" \"webpack serve --config ./config/webpack/demo/webpack.config.dev.js --static demo/js --entry ./demo/js/app\"",
"start:ts": "concurrently --raw \"pnpm:build:typescript --watch\" \"webpack serve --config ./config/webpack/demo/webpack.config.dev.js --static demo/ts --entry ./demo/ts/app\"",
"check": "wireit",
"check:ci": "wireit",
"check:debug": "cross-env WIREIT_PARALLEL=1 pnpm check",
"clean:build": "rimraf coverage \"packages/*/{dist,es,lib}\"",
"clean:cache": "wireit",
Expand Down Expand Up @@ -183,11 +182,6 @@
"types:check"
]
},
"check:ci": {
"dependencies": [
"check"
]
},
"build": {
"dependencies": [
"./packages/victory-native:build",
Expand Down