Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where VictoryChart would throw an unhandled exception whe… #2536

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

gwynethrose
Copy link
Contributor

@gwynethrose gwynethrose commented Dec 15, 2022

Fixed an issue (see #2391) where VictoryChart would throw an unhandled exception when passed null children.

Note that this does currently ignore any non-element children passed into VictoryChart, which matches our documentation. I didn't see any use cases where we'd actually want to show something like a string or a number, but we can go with a less broad check if needed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Latest commit: 9218941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-chart Patch
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants