update components

FormidableLabs · Dec 2, 2023 · e35f9be · e35f9be
1 parent f3524db
commit e35f9be
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 12 deletions.
diff --git a/docs/src/partials/gallery/preview.js b/docs/src/partials/gallery/preview.js
@@ -6,9 +6,12 @@ import ReactDOMServer from "react-dom/server";
 import { transform } from "babel-standalone";
 
 const PreviewWrapper = styled.div``;
-
+const defaultProps = {
+  previewComponent: "div",
+}
 // <Preview> component from component-playground without updating
-const Preview = (props) => {
+const Preview = (_props) => {
+  const props = {...defaultProps,_props}
   let ref = useRef();
 
   const compileCode = () => {
@@ -51,7 +54,7 @@ const Preview = (props) => {
 
   const executeCode = () => {
     const mountNode = ref;
-    const { scope, noRender, previewComponent="div" } = props;
+    const { scope, noRender, previewComponent } = props;
     const tempScope = [];
 
     Object.keys(scope).forEach((s) => tempScope.push(scope[s]));

diff --git a/docs/src/partials/sidebar/index.js b/docs/src/partials/sidebar/index.js
@@ -107,8 +107,13 @@ const getMatchTree = (link, filterTerm) => {
   }
   return [];
 };
+const defaultProps = {
+  className:""
+}
 
-const Sidebar = ({ className="", content, onCloseClick }) => {
+const Sidebar = (_props) => {
+  const props = {...defaultProps,_props}
+  const { className, content, onCloseClick } = props
   const location = useLocation();
   const [filteredResults, setFilteredResults] = useState(content);
   const [filterTerm, setFilterTerm] = useState("");

diff --git a/packages/victory-area/src/area.tsx b/packages/victory-area/src/area.tsx
@@ -92,22 +92,29 @@ const evaluateProps = (props: AreaProps) => {
   return assign({}, props, { ariaLabel, desc, id, style, tabIndex });
 };
 
+const defaultProps={
+  groupComponent: <g />,
+  pathComponent: <Path />,
+  role: "presentation",
+  shapeRendering: "auto",
+}
+
 /**
  * The area primitive used by VictoryArea
  */
 export const Area: React.FC<AreaProps> = (props) => {
-  props = evaluateProps(props);
+  props = evaluateProps({...defaultProps,...props});
   const {
     ariaLabel,
-    role = "presentation",
-    shapeRendering = "auto",
+    role,
+    shapeRendering,
     className,
     polar,
     origin,
     data,
-    pathComponent = <Path />,
+    pathComponent,
     events,
-    groupComponent = <g />,
+    groupComponent,
     clipPath,
     id,
     style,
@@ -137,7 +144,7 @@ export const Area: React.FC<AreaProps> = (props) => {
   };
 
   const area = React.cloneElement(
-    pathComponent,
+    pathComponent!,
     assign(
       {
         key: `${id}-area`,
@@ -153,7 +160,7 @@ export const Area: React.FC<AreaProps> = (props) => {
 
   const line = renderLine
     ? React.cloneElement(
-        pathComponent,
+        pathComponent!,
         assign(
           {
             key: `${id}-area-stroke`,
@@ -166,7 +173,7 @@ export const Area: React.FC<AreaProps> = (props) => {
     : null;
 
   return renderLine
-    ? React.cloneElement(groupComponent, userProps, [area, line])
+    ? React.cloneElement(groupComponent!, userProps, [area, line])
     : area;
 };