Skip to content

Commit

Permalink
cleaning up actions, seeing if setup can be skipped before building m…
Browse files Browse the repository at this point in the history
…ain for comparison
  • Loading branch information
nstolpe committed Nov 5, 2024
1 parent 475a4a2 commit bb9f5cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
10 changes: 3 additions & 7 deletions .github/actions/bundle-size/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,12 @@ runs:
- name: Checkout base branch
uses: actions/checkout@v4
with:
# ref: "main"
ref: ${{ inputs.branch }}
path: br-base

- name: see what's in pr-base
shell: bash
run: ls -al ./br-base

- name: setup
uses: ./br-base/.github/actions/setup
# main is checked out into ./br-base. It needs to be setup and built
# - name: setup
# uses: ./br-base/.github/actions/setup

- name: Build main
shell: bash
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,12 @@ jobs:
- name: Types
run: pnpm types:check

# bundle_size:
# runs-on: ubuntu-latest
# steps:
- name: 📄 Bundle size report
uses: ./.github/actions/bundle-size # path to composite action
with:
paths: "packages/**/dist/*.min.js"
onlyDiff: "true"
# branch: "develop" # branch to compare to
header: "Bundle size report" # PR comment header
# ghToken: ${{ secrets.GITHUB_TOKEN }} # github token

format:
needs: [build]
Expand Down

0 comments on commit bb9f5cb

Please sign in to comment.