Skip to content

Commit

Permalink
added another temporary analysis verifier function
Browse files Browse the repository at this point in the history
formatted
removed unused import
  • Loading branch information
nstolpe committed Nov 5, 2024
1 parent db46047 commit 835fc1b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
3 changes: 3 additions & 0 deletions packages/victory-candlestick/src/helper-methods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -486,3 +486,6 @@ export const getBaseProps = (initialProps, fallbackProps) => {
return childProps;
}, initialChildProps);
};

// @TODO: remove this before merging, it's just for verifying the analysis and report.
const fake = () => "fake";
21 changes: 10 additions & 11 deletions packages/victory-candlestick/src/victory-candlestick.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
VictoryCommonProps,
VictoryDatableProps,
VictoryLabelStyleObject,
VictoryLabelableProps,
VictoryMultiLabelableProps,
VictoryStyleObject,
NumberOrCallback,
Expand Down Expand Up @@ -43,8 +42,8 @@ export type VictoryCandlestickLabelsType =

export interface VictoryCandlestickProps
extends Omit<VictoryCommonProps, "polar">,
VictoryDatableProps,
VictoryMultiLabelableProps {
VictoryDatableProps,
VictoryMultiLabelableProps {
candleColors?: {
positive?: string;
negative?: string;
Expand Down Expand Up @@ -72,13 +71,13 @@ export interface VictoryCandlestickProps
highLabelComponent?: React.ReactElement;
highLabels?: VictoryCandlestickLabelsType;
labelOrientation?:
| OrientationTypes
| {
open?: OrientationTypes;
close?: OrientationTypes;
low?: OrientationTypes;
high?: OrientationTypes;
};
| OrientationTypes
| {
open?: OrientationTypes;
close?: OrientationTypes;
low?: OrientationTypes;
high?: OrientationTypes;
};
low?: StringOrNumberOrCallback | string[];
lowLabelComponent?: React.ReactElement;
lowLabels?: VictoryCandlestickLabelsType;
Expand Down Expand Up @@ -315,4 +314,4 @@ export const bundleSizeIsDifferent = () => {
const z = "the bundle size should be different";

return { x, y, z };
}
};

0 comments on commit 835fc1b

Please sign in to comment.