fixed typing for addEvents.renderData, moved bar shouldRenderDatum ar…

…gument to static property
FormidableLabs · Nov 15, 2024 · 7839bdb · 7839bdb
1 parent d84155d
commit 7839bdb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/victory-bar/src/victory-bar.tsx b/packages/victory-bar/src/victory-bar.tsx
@@ -128,7 +128,9 @@ class VictoryBarBase extends React.Component<VictoryBarProps> {
     "groupComponent",
     "containerComponent",
   ];
-
+  // passed to addEvents.renderData to prevent data props with undefined _x or _y from excluding data from render.
+  // used when inside of VictoryZoomContainer
+  static shouldRenderDatum = () => true;
   // Overridden in native versions
   shouldAnimate() {
     return !!this.props.animate;
@@ -144,7 +146,7 @@ class VictoryBarBase extends React.Component<VictoryBarProps> {
 
     let children;
     if (props.groupComponent.type === VictoryClipContainer) {
-      children = this.renderData(props, () => true);
+      children = this.renderData(props, VictoryBarBase.shouldRenderDatum);
     } else {
       children = this.renderData(props);
     }

diff --git a/packages/victory-core/src/victory-util/add-events.tsx b/packages/victory-core/src/victory-util/add-events.tsx
@@ -57,7 +57,7 @@ export interface EventsMixinClass<TProps> {
   ): React.ReactElement;
   cacheValues<TThis>(this: TThis, obj: Partial<TThis>): void;
   getEventState: typeof Events.getEventState;
-  renderData(props: TProps);
+  renderData(props: TProps, shouldRenderDatum?: () => boolean);
   renderContinuousData(props: TProps);
   animateComponent(
     props: TProps,