Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app: update ios AppAuth dependency #1049

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

djm158
Copy link
Contributor

@djm158 djm158 commented Jan 7, 2025

Description

Fixes the following issue when running pod install from examples/demo/ios:

[!] CocoaPods could not find compatible versions for pod "AppAuth":
  In snapshot (Podfile.lock):
    AppAuth (= 1.7.5, >= 1.7.3)

  In Podfile:
    react-native-app-auth (from `../../../node_modules/react-native-app-auth`) was resolved to 8.0.1, which depends on
      AppAuth (>= 1.7.6)


You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * changed the constraints of dependency `AppAuth` inside your development pod `react-native-app-auth`.
   You should run `pod update AppAuth` to apply changes you've made.

Ran pod update AppAuth and committed the changes.

Additionally, updates the README with the correct path to the demo.

Steps to verify

Follow setup instructions in the README

Clone repository, checkout chore/update-AppAuth-demo-app, then run the following:

cd react-native-app-auth/examples/demo
yarn
(cd ios && pod install)
cd ..
npx react-native run-ios

djm158 added 3 commits January 7, 2025 13:47
ran `pod update AppAuth` and committed changes
* fixes the paths to demo projects in the README
Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: c1fe823

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 6:59pm

@djm158 djm158 changed the title chore(demo): update ios AppAuth dependency in demo app Demo app: update ios AppAuth dependency Jan 9, 2025
Copy link

@JDMathew JDMathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified update ✅

@djm158 djm158 merged commit 1149bf6 into main Jan 14, 2025
3 checks passed
@djm158 djm158 deleted the chore/update-AppAuth-demo-app branch January 14, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants