warnings

FormidableLabs · Dec 4, 2023 · aeb9625 · aeb9625
1 parent e615659
commit aeb9625
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/packages/nextjs/app/migration/components.tsx b/packages/nextjs/app/migration/components.tsx
@@ -38,6 +38,7 @@ export default function ComponentsPage() {
       <h1 className="text-h4">Select</h1>
       <div className="mb-8 mt-2">
         <Select
+          id="demo"
           label="Label"
           placeholder="Placeholder Text"
           options={[

diff --git a/packages/nextjs/components/ProductPage/ProductVariantSelector.tsx b/packages/nextjs/components/ProductPage/ProductVariantSelector.tsx
@@ -31,6 +31,7 @@ export const ProductVariantSelector = ({ variants, selectedVariant, onVariantCha
       ) : (
         <Select
           options={options}
+          id="product-variants-select"
           placeholder="Select a flavour"
           selectedItem={{
             title: selectedVariant?.name ?? "",

diff --git a/packages/shared-ui/components/ProductSort/ProductSort.tsx b/packages/shared-ui/components/ProductSort/ProductSort.tsx
@@ -52,6 +52,7 @@ export const ProductSort: React.FC<ProductSortProps> = ({
         <Select
           label=""
           placeholder={title}
+          id="sort-select"
           selectedItem={selectedItem}
           options={elements}
           className={selectClassName}

diff --git a/packages/shared-ui/components/Select.tsx b/packages/shared-ui/components/Select.tsx
@@ -11,18 +11,20 @@ export interface Props {
   options: Option[];
   label?: string;
   placeholder: string;
+  id: string;
   selectedItem?: Option | null;
   className?: string;
   onChange?: (value?: Option | null) => void;
 }
 
 const itemToString = (item: Option | null) => (item ? item.title : "");
 
-export function Select({ label, placeholder, options, className, selectedItem, onChange }: Props) {
+export function Select({ label, placeholder, options, className, selectedItem, onChange, id }: Props) {
   const { isOpen, getToggleButtonProps, getLabelProps, getMenuProps, highlightedIndex, getItemProps } = useSelect({
     items: options,
     itemToString,
     selectedItem,
+    id,
     onSelectedItemChange({ selectedItem }) {
       onChange && onChange(selectedItem);
     },