refactor(forecast): abbr "a few clouds" better

Forceh91 · Nov 16, 2023 · a87f1e4 · a87f1e4
1 parent efe8cd0
commit a87f1e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/__tests__/abbreviateForecast.test.ts b/src/__tests__/abbreviateForecast.test.ts
@@ -137,6 +137,7 @@ describe("Forecast Truncation", () => {
       "30% chnc of shwrs/tstorms"
     );
     expect(abbreviateForecast("rain or flurries overnight", forecastLengthWanted)).toStrictEqual("rain/flrys ovrngt");
+    expect(abbreviateForecast("a few clouds overnight", forecastLengthWanted)).toStrictEqual("few clouds ovrngt");
   });
 
   test("Wintery weather", () => {

diff --git a/src/lib/conditions/forecast.ts b/src/lib/conditions/forecast.ts
@@ -96,7 +96,7 @@ const removeJoiningWords = (forecast: string) =>
     .replace(/becoming/gi, "bcmg")
     .replace(/increasing/gi, "incr")
     .replace(/diminishing/gi, "dmnshg")
-    .replace(/\sa few/gi, "")
+    .replace(/a few/gi, "few")
     .replace(/with/gi, "w/")
     .replace(/([a-z])\sor\s/gi, "$1/")
     .replace(/and/gi, "&");