Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use beta api, intergrated 5 options #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apankDocero
Copy link
Collaborator

@apankDocero apankDocero commented Oct 31, 2016

Beta API provides better website rendering.
With the current API I sometimes run into svg issues even though it renders correctly on even IE 9.

To use simply add the 'beta' string at the end
var url2png = require('url2png')('API_KEY', 'PRIVATE_KEY', 'beta');

Integrated 5 options 'user_agent', 'unique', 'accept_languages', 'ttl' and 'custom_css_url'.

Current know issues with both the current + beta API's:
When either the 'user_agent' or 'accept_languages' is specified it will only accept url's with out 'http/https' and without a subdirectory. Else it will throw a 500 error and return this -
screen shot 2016-10-31 at 5 50 07 am

Reaching out to support to see if they can help resolve that issue.

@ForbesLindesay
Copy link
Member

I'm no longer using/maintaining this library. Let me know what your npm user name is and I'll add you as an owner on npm so you can publish new versions.

P.S.

I'd recommend an api that accepts an options object like {version: 'beta'} instead of just the 'beta' string literal as this will allow for more options in the future if need be.

@apankDocero
Copy link
Collaborator Author

Thanks! My npm username is apank

@ForbesLindesay
Copy link
Member

Sorry for the delay, you are now an owner of the npm package and ca collaborator on this GitHub repo. Feel free to merge and publish this once you've made it take an options object rather than a plain string.

@leslie-alldridge
Copy link

If this still needs doing @ForbesLindesay I wouldn't mind helping out - cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants