Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bombs behavior and score system #214

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Bombs behavior and score system #214

merged 8 commits into from
Jan 13, 2025

Conversation

evgTSV
Copy link
Contributor

@evgTSV evgTSV commented Jan 9, 2025

Part of #30
Part of #27

Bombs are activated if the player passes through the trigger
Scores are added if the player's bullet hits the bomb

@ForNeVeR ForNeVeR self-requested a review January 9, 2025 21:39
@ForNeVeR ForNeVeR self-assigned this Jan 9, 2025
ForNeVeR
ForNeVeR requested changes Jan 12, 2025
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've left a couple of minor comments.

If you won't fix them yourself, I'm ready to work on them starting from tomorrow.

O21.Game/Animations/PlayerAnimation.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Entities.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Entities.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Entities.fs Outdated Show resolved Hide resolved
O21.Game/Engine/GameField.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Geometry.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Geometry.fs Outdated Show resolved Hide resolved
O21.Game/Engine/Geometry.fs Outdated Show resolved Hide resolved
ForNeVeR
ForNeVeR approved these changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit b4801d4 into ForNeVeR:main Jan 13, 2025
5 checks passed
@evgTSV evgTSV deleted the enemy-behavior branch January 15, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgTSV @ForNeVeR