Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JFO #17 Resolution #124

Closed
wants to merge 1 commit into from
Closed

JFO #17 Resolution #124

wants to merge 1 commit into from

Conversation

cmrn-rhi
Copy link
Member

Resolution for beer issues "Alcoholic beverages in FOODON #17" in the Joint Food Ontology repository.

"- Modifications to beer and beer (<quality>) related terms altered the foodon_product_import.owl file.

  • Depreciated beer; removed from superclasses, added obsolete: as label prefix, added has obsolescence reason, added owl:deprecated = true, and term replaced by beer beverage.

  • Moved the following terms from barley malt beverage to beer beverage:
    ale
    beer (concentrated)
    beer (draft)
    beer (freeze-concentrated)
    beer (light)
    beer (low alcohol)
    beer (made from concentrate)
    beer (small)
    beer with a minimum acidity of 30 mill.-equivalents expressed as naoh
    beer with a second fermentation in cask
    brown beer oud bruin type

  • Added new term lager, under beer beverage, as it is a common type of beer and was missing from FoodOn.

"- Modifications to `beer` and `beer (<quality>)` related terms altered the foodon_product_import.owl file.

- Depreciated `beer`; removed from superclasses, added `obsolete: ` as label prefix, added `has obsolescence reason`, added `owl:deprecated` = `true`, and `term replaced by` `beer beverage`.

- Moved the following terms from `barley malt beverage` to `beer beverage`:
ale
beer (concentrated)
beer (draft)
beer (freeze-concentrated)
beer (light)
beer (low alcohol)
beer (made from concentrate)
beer (small)
beer with a minimum acidity of 30 mill.-equivalents expressed as naoh
beer with a second fermentation in cask
brown beer oud bruin type
brown beer oud bruin type

- Added new term `lager` as it is a common type of beer and was missing from FoodOn."
@cmrn-rhi cmrn-rhi closed this Jan 23, 2021
@cmrn-rhi
Copy link
Member Author

Modifying the beer term so that it's not obsolete but instead a barley based beer.

@cmrn-rhi
Copy link
Member Author

Do not merge. Reopening to see if "failed check" information reappears.

@cmrn-rhi cmrn-rhi reopened this Jan 24, 2021
@cmrn-rhi
Copy link
Member Author

Travis error is irrelevant. Closing branch anyhow due to issue with new lager term IRI. All changes listed (aside from lager) were integrated in pull request #125.

@cmrn-rhi cmrn-rhi closed this Jan 25, 2021
@ddooley ddooley deleted the source-rhiannon-20 branch June 7, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant