Support ligature #267
Support ligature #267
Conversation
|
Any chance this functionality can get merged/implemented any time soon? |
|
I'm just waiting for this feature. Come ooon! |
|
👍 |
| -moz-text-rendering: optimizeLegibility; | ||
| -ms-text-rendering: optimizeLegibility; | ||
| -o-text-rendering: optimizeLegibility; | ||
| text-rendering: optimizeLegibility;| |
There was a problem hiding this comment.
This rule has a significant performance cost. Will this feature work without this rule?
There was a problem hiding this comment.
I know a performance problem of optimizeLegibility. but, ligature fonts needs this property for rendering glyphs on browser. if you set ligature options to false, remove this properties.
lib/fontcustom/scripts/generate.py
Outdated
| elif c == "8": | ||
| c = "eight" | ||
| elif c == "9": | ||
| c = "nine" |
There was a problem hiding this comment.
Not a huge fan of this approach. Consider using an array.
words = ['zero', 'one', 'two', 'three', 'four', 'five', 'six', 'seven', 'eight', 'nine']
return words[c] || cThere was a problem hiding this comment.
I'm fixed this. Please review code.
|
@rosylilly thanks for your work on this, it seems the community would like this feature so it is a valuable addition. Please take a look at my PR comments and resolve the conflicts with master. |
rosylilly
force-pushed
the
support-ligature
branch
3 times, most recently
from
ed48772
to
7964973
Compare
rosylilly
force-pushed
the
support-ligature
branch
from
7964973
to
03db1c6
Compare
|
@JakeBeresford Rebased and Fixed. Please review my codes. |
|
@JakeBeresford Are you busy? I'm waiting for your reply. |
|
I'm going to up this PR. @kaizau or @JakeBeresford It sounds like it was ready to be merged. Is this project unmaintained? |
|
Given the last commit into master is from 3 years ago, probably, the project is unmaintained. |
refs: #21
It's just provide ligature mode to fontcustom.