-
Notifications
You must be signed in to change notification settings - Fork 27
Universal way to check pull request
A thing you can start with is to read through your translation at least once time but preferably a few times. That will lead to you probably being able to catch most grammar issues. That will save you and the core contributors time because we will have fewer PRs to deal with. In the word grammar, I don't only mean the spelling of words and how sentences are built up. I also mean things like having double space. As then someone else will have to remove the double spaces. We start to check so the file is up to date.
After we are done with that we start to check so the file is up to date.
The English file:
If the file look like this:
Will we tell the person to update to the latest version.
If the file that will be merged looks like this:
Target-version-The version code for target PO file, e.g. 1.2.1
It needs to be updated as the source and target versions need to match!
Also a thing to take in consideration. Every new day you update your translation file you will need to update the Target-Last-Modified date.
Other examples which will make your file not get merged in:
Not having the "" although as long as you use programs like poedit will you not have to worry about that.