Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging more suitable for log monitoring softwares #1275

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 3, 2024

Issue

The util function displayServerURL and configuration errors print logs on several lines which are not suitable for logging software. It would be more readable to log information on a single line.

Solution and steps

  • Mark displayServerURL as deprecated and use services.get(Logger).info(Listening on port ${port}...) in projects instead.
  • Simplify config errors.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 3, 2024
8 tasks
@LoicPoullain LoicPoullain merged commit 8299833 into v4-5-0 Aug 3, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the deprecation-server-url branch August 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant