Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage admin links in PHP #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YKWeyer
Copy link

@YKWeyer YKWeyer commented Jul 21, 2020

This MR moves the JS/CSS changes performed in the admin menu to a single filter in PHP.

It brings following benefits:

  • Outputting the <style> tag was breaking most XHR calls
  • Adding the frontend link in PHP makes it translatable and more flexible (it will generate a link to the frontend even if it isn't the root of the current domain being viewed)

Adding `<style>` was breaking most XHR calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant