Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Cos #108

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Adding support for Cos #108

merged 2 commits into from
Dec 6, 2024

Conversation

dstarkenburg
Copy link
Contributor

@dstarkenburg dstarkenburg commented Dec 6, 2024

Adding support for Cos as implemented in ONNX.

NOTE: Test case for Cos limited to Float32 tensors! (ONNXRunTime has no Float64 kernel for Cos) source

PR Checklist

  • Tests are added
  • Documentation, if applicable

@dfdx dfdx merged commit b5b9f52 into FluxML:master Dec 6, 2024
2 checks passed
@dfdx
Copy link
Collaborator

dfdx commented Dec 6, 2024

Thanks again!
Since you plan to make many PRs, I don't bump version of the package after each of them. Nevertheless, feel free to update the version yourself if/when you believe you've accumulated enough changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants