Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docs & @layer for Functors.jl v0.5 #2509

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcabbott
Copy link
Member

After FluxML/Functors.jl#51 we should stop saying that you need either @layer or @functor for Flux to find your parameters.

This PR:

  • defines a new macro Flux.@functor which prints a depwarn & then calls @layer
  • removes the code from @layer which printed other depwarns
  • removes the code from @layer which defines functor

WIP, more doc changes needed.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@mcabbott mcabbott added this to the v0.15 milestone Oct 28, 2024
@CarloLucibello
Copy link
Member

Functors v0.5 is out

@CarloLucibello
Copy link
Member

We can continue with this now that Functors v0.5 is in with #2525
This is the last item in the v0.15 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants