Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] gives sectech restockers a name #963

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25415
Original PR: tgstation/tgstation#80098

About The Pull Request

uh. title? gives sectech restock units a machine_name so they actually tell you what they restock

Why It's Good For The Game

sectech restockers are no longer just named "generic restocking units"

Changelog

🆑 Hatterhat
fix: SecTech restocking units are now actually named SecTech restocking units, and not Generic restocking units.
/:cl:

* gives sectech restockers a name (#80098)

## About The Pull Request
uh. title? gives sectech restock units a `machine_name` so they actually
tell you what they restock

## Why It's Good For The Game
sectech restockers are no longer just named "generic restocking units"

## Changelog

:cl:
fix: SecTech restocking units are now actually named SecTech restocking
units, and not Generic restocking units.
/:cl:

---------

Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com>

* gives sectech restockers a name

---------

Co-authored-by: Hatterhat <[email protected]>
Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com>
@Iajret Iajret merged commit ba521cd into master Dec 4, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25415 branch December 4, 2023 23:38
AnywayFarus added a commit that referenced this pull request Dec 4, 2023
Iajret pushed a commit that referenced this pull request Feb 15, 2024
* Reduces Time For Nightmare To Gain a Critical Strike (#81317)

## About The Pull Request

This PR reduces the amount of time it takes for Nightmare to gain a
critical strike whilst in jaunt (15 > 7 seconds)

## Why It's Good For The Game

Having watched players use the new mechanic added to Nightmare's Light
Eater in #80670, I've recognized that the 15 second requirement is
extremely clunky in practice, as it was a carryover from when Nightmare
got crits from being out of jaunt as opposed to staying in. Since
Nightmare's job requires it to usually be out of jaunt smashing lights
or APCs when it isn't engaged in combat, reducing the time it takes
while in jaunt to gain a critical strike allows Nightmare to get more
use out of the mechanic without throwing off their general game plan so
much.

## Changelog

:cl:
balance: Nightmare's Light Eater takes less time in jaunt to gain a
critical strike, being reduced to 7 seconds from 15 seconds.
/:cl:

* Reduces Time For Nightmare To Gain a Critical Strike

---------

Co-authored-by: IndieanaJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants