[MIRROR] Adds investigative logging for vent overclocking #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…] (#25271) * Adds investigative logging for vent overclocking (#79932) ## About The Pull Request Basically what it says in the title. We added a feature which could destroy vents but forgot to log who turned it on and forgot to turn it off. Now the Investigate log for atmos will record who toggled overclocking, whether they turned it on or off, and whenever a vent was destroyed as a result of overlock damage. Also this removes a little bit of code which never ran, as a result of that it checked the integrity of the vent _before_ damaging it and does not process after being damaged to destruction. No changelog because it's not player facing. * Adds investigative logging for vent overclocking --------- Co-authored-by: Jacquerel <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* SM cascade warnings only show to players in game (#81343) ## About The Pull Request Fixes tgstation/tgstation#81337 ## Changelog :cl: LT3 fix: SM cascade delam messages no longer display to clients not in game /:cl: * SM cascade warnings only show to players in game --------- Co-authored-by: lessthanthree <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 9, 2024
* SM cascade warnings only show to players in game (#81343) ## About The Pull Request Fixes tgstation/tgstation#81337 ## Changelog :cl: LT3 fix: SM cascade delam messages no longer display to clients not in game /:cl: * SM cascade warnings only show to players in game --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: lessthanthree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25271
Original PR: tgstation/tgstation#79932
About The Pull Request
Basically what it says in the title.
We added a feature which could destroy vents but forgot to log who turned it on and forgot to turn it off.
Now the Investigate log for atmos will record who toggled overclocking, whether they turned it on or off, and whenever a vent was destroyed as a result of overlock damage.
Also this removes a little bit of code which never ran, as a result of that it checked the integrity of the vent before damaging it and does not process after being damaged to destruction.
No changelog because it's not player facing.