Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes a runtime in advanced camera console #843

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25273
Original PR: tgstation/tgstation#79938

About The Pull Request

Fixes Skyrat-SS13/Skyrat-tg#25222

One of the procs was lacking a client check. Also converted some other client var accesses to use the ? operator as they can become null mid execution if the user logs out.

Why It's Good For The Game

Bugfix

Changelog

🆑 vinylspiders
fix: fixed a null client runtime in advanced camera console
/:cl:

…273)

* Fixes a runtime in advanced camera console (#79938)

## About The Pull Request

Fixes Skyrat-SS13/Skyrat-tg#25222

One of the procs was lacking a `client` check. Also converted some other
`client` var accesses to use the `?` operator as they can become null
mid execution if the user logs out.

## Why It's Good For The Game

Bugfix

## Changelog

:cl:
fix: fixed a null client runtime in advanced camera console
/:cl:

---------

Co-authored-by: SyncIt21 <110812394+SyncIt21@ users.noreply.github.com>

* Fixes a runtime in advanced camera console

---------

Co-authored-by: Bloop <[email protected]>
Co-authored-by: SyncIt21 <110812394+SyncIt21@ users.noreply.github.com>
@Iajret Iajret merged commit 7c89863 into master Nov 27, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25273 branch November 27, 2023 09:14
AnywayFarus added a commit that referenced this pull request Nov 27, 2023
Iajret pushed a commit that referenced this pull request Feb 9, 2024
You can now move and talk through statues and mannequins

Co-authored-by: John Willard <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple flaky test failures in create_and_destroy, monkey_business
3 participants