Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes fullupgrade chem dispenser not spawning with all their chemicals #771

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25180
Original PR: tgstation/tgstation#79858

About The Pull Request

Fixes Skyrat-SS13/Skyrat-tg#24911

Tin. They were spawning with only the emagged reagents. This was not an issue for the drink dispensers because they call the parent after adjusting the reagent lists. It needs to be done that way so that RefreshParts() gets called after adjusting the lists.

Before/after

dreamseeker_H0sicTrScp

image

Why It's Good For The Game

Fixes a bug

Changelog

🆑 vinylspiders
fix: fullupgrade chem dispensers will now spawn with all their chems
/:cl:

… chemicals [MDB IGNORE] (#25180)

* Fixes fullupgrade chem dispenser not spawning with all their chemicals (#79858)

## About The Pull Request

Fixes Skyrat-SS13/Skyrat-tg#24911

Tin. They were spawning with only the emagged reagents. This was not an
issue for the drink dispensers because they call the parent after
adjusting the reagent lists. It needs to be done that way so that
`RefreshParts()` gets called after adjusting the lists.

<details>
<summary>Before/after</summary>

![dreamseeker_H0sicTrScp](https://github.com/tgstation/tgstation/assets/13398309/649ab998-8308-4efa-be25-f4942ecab175)

![image](https://github.com/tgstation/tgstation/assets/13398309/9709dfa3-bf64-40f8-ab24-8508255d17ae)

</details>

## Why It's Good For The Game

Fixes a bug

## Changelog

:cl:
fix: fullupgrade chem dispensers will now spawn with all their chems
/:cl:

* Fixes fullupgrade chem dispenser not spawning with all their chemicals

---------

Co-authored-by: Bloop <[email protected]>
@ReezeBL ReezeBL merged commit 5c759f1 into master Nov 23, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25180 branch November 23, 2023 19:28
AnywayFarus added a commit that referenced this pull request Nov 23, 2023
Iajret pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interdyne turrets and dispensers with T1 parts
3 participants