[MIRROR] Makes heads on pikes render correctly. #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes heads on pikes render correctly. (#79863) ## About The Pull Request Fixes #59037. This PR makes heads on pikes actually appear properly offset so that they're impaled on the spike instead of halfway down the shaft. In addition, the heads will actually appear on the correct layer, rather than sometimes being rendered on the _UI layer._ This means they will not inexplicably be visible to blind players.  ## Why It's Good For The Game Judging from the screenshots in the PR that added these six years ago, this has actually _never_ looked correct. For the first time, this makes heads on pikes actually look like they're meant to, rather than having way too much of the spear shoved out the top of the head. Also, fixes a fairly egregious rendering error that makes blind people see mysterious heads in the void. ## Changelog :cl: fix: Heads impaled on spears now render in the correct place on the tip, instead of halfway down the shaft. fix: Blind personnel are no longer able to magically see heads impaled on spears from a distance. /:cl: * Makes heads on pikes render correctly. --------- Co-authored-by: lizardqueenlexi <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 21, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 9, 2024
* donator item switch e * ea ssdd * Update donator_clothing.dm * Update donator_clothing.dm * Update mask.dmi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25170
Original PR: tgstation/tgstation#79863
About The Pull Request
Fixes #59037.
This PR makes heads on pikes actually appear properly offset so that they're impaled on the spike instead of halfway down the shaft. In addition, the heads will actually appear on the correct layer, rather than sometimes being rendered on the UI layer. This means they will not inexplicably be visible to blind players.
Why It's Good For The Game
Judging from the screenshots in the PR that added these six years ago, this has actually never looked correct. For the first time, this makes heads on pikes actually look like they're meant to, rather than having way too much of the spear shoved out the top of the head.
Also, fixes a fairly egregious rendering error that makes blind people see mysterious heads in the void.
Changelog
🆑 lizardqueenlexi
fix: Heads impaled on spears now render in the correct place on the tip, instead of halfway down the shaft.
fix: Blind personnel are no longer able to magically see heads impaled on spears from a distance.
/:cl: