Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes the recycler's missing dir variable #753

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25153
Original PR: tgstation/tgstation#79834

About The Pull Request

Yeah so like, for some reason the dir variable on meta's recycler was just gone so it faced directly the wall. What a disaster!

Why It's Good For The Game

It works again now.

Changelog

🆑 EuSouAFazer
fix: Meta's recycler works again
/:cl:

* Fixes the recycler's missing dir variable (#79834)

Yeah so like, for some reason the dir variable on meta's recycler was
just gone so it faced directly the wall. What a disaster!

It works again now.
:cl:
fix: Meta's recycler works again
/:cl:

* Fixes the recycler's missing dir variable

---------

Co-authored-by: Fazzie <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror Fix labels Nov 21, 2023
@Iajret Iajret merged commit a029d30 into master Nov 21, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25153 branch November 21, 2023 23:43
AnywayFarus added a commit that referenced this pull request Nov 21, 2023
Iajret pushed a commit that referenced this pull request Feb 3, 2024
…est noise when turning their pages (#753)

* The "Guide to Advanced Mimery" series now make but the faintest noise when turning their pages (#81068)

## About The Pull Request

What it says on the tin. To fit with the description of volume 1 ("The
pages don't make any sound when turned."), they now use the sound of
faint rustling instead of the default page-turning sound effect.

Pictured below (you may wish to turn up your volume):


https://github.com/tgstation/tgstation/assets/80640114/e9867815-8e33-47a5-83e2-19fc979e15d6
## Why It's Good For The Game

Makes the book's behaviour consistent with their description, plus it's
just fitting, isn't it?.
## Changelog
:cl:
sound: The Guide to Advanced Mimery book series now only make a very
faint noise when turning their pages, in order to match their
description
/:cl:

* The "Guide to Advanced Mimery" series now make but the faintest noise when turning their pages

---------

Co-authored-by: A miscellaneous Fern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Map Modification Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants