Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes cursed/bad luck initializing with the wrong amount of incidents #751

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25162
Original PR: tgstation/tgstation#79846

About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident. incidents_left should not have a default value for the arg, as if it's called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

Changelog

🆑 LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1 incident
/:cl:

…incidents [MDB IGNORE] (#25162)

* Fixes cursed/bad luck initializing with the wrong amount of incidents (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:

* Fixes cursed/bad luck initializing with the wrong amount of incidents

---------

Co-authored-by: lessthanthree <[email protected]>
@Iajret Iajret merged commit 95db2b5 into master Nov 21, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25162 branch November 21, 2023 20:38
AnywayFarus added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursed quirk only triggers once per round
3 participants