[MIRROR] Poly speech/memory fix. #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Poly speech/memory fix. (#79851) Simple fix for Poly's AI, Read Memory was returning null into a list used for Poly's speech causing a stack error. I changed the returned value to the empty returnable list to negate this problem. Fixes #79844 Fixes #79859 Fixes #79865 First time making a pull request on Github, please bear with me if i make any mistakes. Less errors on the servers side. Probably saving the headache of debugging from some other poor soul. --------- Co-authored-by: san7890 <the@ san7890.com> * Poly speech/memory fix. --------- Co-authored-by: shwb1 <[email protected]> Co-authored-by: san7890 <the@ san7890.com>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-25159
Iajret
pushed a commit
that referenced
this pull request
Feb 3, 2024
* [Testing] Fixing cleanbot AI related CI runtimes * Update find_and_set.dm * Why does this still keep happening?!!?!? * Update cleanbot_ai.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25159
Original PR: tgstation/tgstation#79851
About The Pull Request
Simple fix for Poly's AI, Read Memory was returning null into a list used for Poly's speech causing a stack error. I changed the returned value to the empty returnable list to negate this problem.
Fixes #79844
Fixes #79859
Fixes #79865
First time making a pull request on Github, please bear with me if i make any mistakes.
Why It's Good For The Game
Less errors on the servers side. Probably saving the headache of debugging from some other poor soul.