[MIRROR] Floor Viruses Return Unique IDs #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Floor Viruses Return Unique IDs (#79840) ## About The Pull Request Changes the floor disease viruses so that they return unique IDs (their typepath) instead of numeric IDs generated like normal Advanced viruses do. ## Why It's Good For The Game Bug reported downstream: Skyrat-SS13/Skyrat-tg#24724 Skyrat-SS13/Skyrat-tg#24643 When players make a virus with the symptoms of only Fever or Headache in the pandemic (which are common to buff viruses), those will generate with the same ID as gastritium or carpellosis, because the floor viruses generated IDs like they were normal advanced viruses. If the virologist creates a virus sample from that, it will give it the subtype of the floor virus, and then if that sample is used to generate a healing virus the healing virus will get the symptoms and name of the healing virus but keep the subtype (including cure and other affects, like burping tritium) of the floor virus. This change makes it so that the floor viruses cant be modified in the pandemic (trying to modify it and printing a culture tube will just make the culture tube of the original floor virus), and so that virology players can't accidentally create healing virus with those nasty effects. The typepath was used as the ID to mimic what it looks like for the other (non-advanced) unique diseases. If you can think of a better way to fix this, please let me know, I was just getting tired of having to put up with burping green gas to have a standard healing virus if the virologist wasn't aware of this bug. ## Changelog :cl: fix: healing viruses can no longer have floor virus side effects /:cl: * Floor Viruses Return Unique IDs --------- Co-authored-by: Thlumyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25152
Original PR: tgstation/tgstation#79840
About The Pull Request
Changes the floor disease viruses so that they return unique IDs (their typepath) instead of numeric IDs generated like normal Advanced viruses do.
Why It's Good For The Game
Bug reported downstream:
Skyrat-SS13/Skyrat-tg#24724
Skyrat-SS13/Skyrat-tg#24643
When players make a virus with the symptoms of only Fever or Headache in the pandemic (which are common to buff viruses), those will generate with the same ID as gastritium or carpellosis, because the floor viruses generated IDs like they were normal advanced viruses. If the virologist creates a virus sample from that, it will give it the subtype of the floor virus, and then if that sample is used to generate a healing virus the healing virus will get the symptoms and name of the healing virus but keep the subtype (including cure and other affects, like burping tritium) of the floor virus.
This change makes it so that the floor viruses cant be modified in the pandemic (trying to modify it and printing a culture tube will just make the culture tube of the original floor virus), and so that virology players can't accidentally create healing virus with those nasty effects.
The typepath was used as the ID to mimic what it looks like for the other (non-advanced) unique diseases.
If you can think of a better way to fix this, please let me know, I was just getting tired of having to put up with burping green gas to have a standard healing virus if the virologist wasn't aware of this bug.
Changelog
🆑 Thlumyn
fix: healing viruses can no longer have floor virus side effects
/:cl: