[MIRROR] Fixes body collision causing a stun, despite a successful block. #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock. [MDB IGNORE] (#25146) * Fixes body collision causing a stun, despite a successful block. (#79824) ## About The Pull Request Puts a block check into the ``throw_impact()`` of carbon mobs. ## Why It's Good For The Game I'm touching on a lot of 'get around shields' stuns, and this has been a big one for the better part of a few years and potentially not even intentional. I would say it gained its largest popularity when it became weaponized with fireman carrying. Despite seemingly rolling to block, blocking a body hitting you doesn't actually do anything at all. This reminds me a bit of energy bolas. So I fixed it? I think, there might be a better fix, I'm just replicating code present in xenomorph tackles. This shit sucks, please recommend a better fix if you know it. ## Changelog :cl: fix: When you successfully block a body collision, it does something rather than nothing at all. /:cl: * Fixes body collision causing a stun, despite a successful block. --------- Co-authored-by: necromanceranne <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 21, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Minor STuff 1 * More stuff 2: tarkonian boogaloo * THE solar array. * Yeah this is annoying to deal with. * Because Common Sense Doesn't Exist. * That might actually track better. * Lets just make these more bearable. * they dont need cable. * cant be pocket. * Fix The Polarizers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25146
Original PR: tgstation/tgstation#79824
About The Pull Request
Puts a block check into the
throw_impact()of carbon mobs.Why It's Good For The Game
I'm touching on a lot of 'get around shields' stuns, and this has been a big one for the better part of a few years and potentially not even intentional. I would say it gained its largest popularity when it became weaponized with fireman carrying.
Despite seemingly rolling to block, blocking a body hitting you doesn't actually do anything at all. This reminds me a bit of energy bolas. So I fixed it? I think, there might be a better fix, I'm just replicating code present in xenomorph tackles. This shit sucks, please recommend a better fix if you know it.
Changelog
🆑 necromanceranne
fix: When you successfully block a body collision, it does something rather than nothing at all.
/:cl: