[MIRROR] Fixes a race condition in mutations code #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a race condition in mutations code (#79829) ## About The Pull Request One of the timers has a callback to the `modify()` proc which also doesn't check whether the mutation owner has been deleted since the timer began, potentially resulting in a runtime.  ## Why It's Good For The Game Fixes bugs ## Changelog :cl: fix: fixed a race condition with mutations /:cl: * Fixes a race condition in mutations code --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25116
Original PR: tgstation/tgstation#79829
About The Pull Request
One of the timers has a callback to the
modify()proc which also doesn't check whether the mutation owner has been deleted since the timer began, potentially resulting in a runtime.Why It's Good For The Game
Fixes bugs
Changelog
🆑 vinylspiders
fix: fixed a race condition with mutations
/:cl: