[MIRROR] Fixes bug with high luminosity eyes, & fixes eyes being on the wrong side of the head! #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he wrong side of the head! [MDB IGNORE] (#25098) * Fixes bug with high luminosity eyes, & fixes eyes being on the wrong side of the head! (#79760) * Fixes bug with high luminosity eyes, & fixes eyes being on the wrong side of the head! * Screenshot test * Merge skew --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25098
Original PR: tgstation/tgstation#79760
About The Pull Request
Fixes Skyrat-SS13/Skyrat-tg#24752
Yep. I was investigating a bug caused by the recent light eater fix that ended up breaking these robotic eyes. This will be my third time fixing them so I've prepared a unit test for it because I would not like there to be a fourth.
While investigating the robotic eyes bug, found that eyes themselves are not rendering properly; the east/west sprites needed to be swapped. It has probably gone unnoticed for so long because most players do not have heterochromia.
Seen here are the magical migrating eyeballs
Someone else at some point decided that the eye sprites were wrong and edited them to be their way. Except now they're actually mismatched. Fixed that so they are consistent and correct when turning now.
Also rephrases some of the tooltips in the High Luminosity eyes UI to be a little bit clearer.
Why It's Good For The Game
Having your eyes not magically jump to the other side of your face when you turn is probably a good thing...
Fixed eyes
Moth version
Jelly eyes
Changelog
🆑 vinylspiders
fix: fixes bug that was preventing high luminosity eyes' light from turning on
fix: fixes eyes being on the wrong side of the head when facing east/west
/:cl: