[MIRROR] Debug chem synthesizer works & related code cleanup #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [MDB IGNORE] (#25109) * [NO GBP] Debug chem synthesizer works & related code cleanup (#79616) ## About The Pull Request 1. Fixes #79610 It works and the UI has also been updated to match that of chem dispenser and it displays an input list for adding reagents now  2. Created a common component for chem dispenser, portable chem dispenser & debug chem synthesizer to share in the UI code. 3. Moved portable chem mixer to modules/reagents/machinery folder to group them under the chemistry category ## Changelog :cl: fix: debug chem synthesizer works again. cleaned up chem dispenser, portable chem dispenser & debug chem synthesizer ui code qol: ui for displaying beaker reagents for debug chem synthesizer has been improved. Now displays input list for adding reagents /:cl: * [NO GBP] Debug chem synthesizer works & related code cleanup --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Fixes Cult voting for a leader (#81169) ## About The Pull Request With the recent changes to polling, it seems like it didn't properly poll cultists, I fixed that and fixed other issues with it (such as it telling players that they are signing up to BE a cult leader, when they arent). Also fixed the button to put yourself forward as cult leader, it properly removes and gives itself when necessary. ## Why It's Good For The Game Cult button works again how cool is that Closes tgstation/tgstation#80620 ## Changelog :cl: fix: Cultists can now vote for a Cult leader again. /:cl: * Fixes Cult voting for a leader --------- Co-authored-by: John Willard <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Fixes Cult voting for a leader (#81169) ## About The Pull Request With the recent changes to polling, it seems like it didn't properly poll cultists, I fixed that and fixed other issues with it (such as it telling players that they are signing up to BE a cult leader, when they arent). Also fixed the button to put yourself forward as cult leader, it properly removes and gives itself when necessary. ## Why It's Good For The Game Cult button works again how cool is that Closes tgstation/tgstation#80620 ## Changelog :cl: fix: Cultists can now vote for a Cult leader again. /:cl: * Fixes Cult voting for a leader --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25109
Original PR: tgstation/tgstation#79616
About The Pull Request
Fixes #79610
It works and the UI has also been updated to match that of chem dispenser and it displays an input list for adding reagents now
Created a common component for chem dispenser, portable chem dispenser & debug chem synthesizer to share in the UI code.
Moved portable chem mixer to modules/reagents/machinery folder to group them under the chemistry category
Changelog
🆑 SyncIt21
fix: debug chem synthesizer works again. cleaned up chem dispenser, portable chem dispenser & debug chem synthesizer ui code
qol: ui for displaying beaker reagents for debug chem synthesizer has been improved. Now displays input list for adding reagents
/:cl: