Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes an incorrect term in roundstart tips. #712

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25107
Original PR: tgstation/tgstation#79826

About The Pull Request

A few roundstart tips erroneously referred to suit-slot clothing as "exosuits". I've changed the wording to refer to the suits and the suit slot properly.

Why It's Good For The Game

In-game, "exosuit" refers solely to mechs, i.e. the exosuit fabricator and exosuit equipment. Using this term for suit clothing muddles the actual meaning of these roundstart tips.

Changelog

🆑 lizardqueenlexi
spellcheck: Some roundstart tips have been made clearer regarding "suits" vs. "exosuits".
/:cl:

…5107)

* Fixes an incorrect term in roundstart tips. (#79826)

## About The Pull Request

A few roundstart tips erroneously referred to suit-slot clothing as
"exosuits". I've changed the wording to refer to the suits and the suit
slot properly.
## Why It's Good For The Game

In-game, "exosuit" refers solely to mechs, i.e. the exosuit fabricator
and exosuit equipment. Using this term for suit clothing muddles the
actual meaning of these roundstart tips.
## Changelog
:cl:
spellcheck: Some roundstart tips have been made clearer regarding
"suits" vs. "exosuits".
/:cl:

* Fixes an incorrect term in roundstart tips.

---------

Co-authored-by: lizardqueenlexi <[email protected]>
@Iajret Iajret merged commit fe7d635 into master Nov 19, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25107 branch November 19, 2023 17:21
AnywayFarus added a commit that referenced this pull request Nov 19, 2023
Iajret pushed a commit that referenced this pull request Jan 31, 2024
* northstar mail sorting room access and door nitpick (#81179)

## About The Pull Request

back from the grave for yet another minor access nitpick that was
brought to my attention.

northstars mail room had an awkward access woopsy attached to it, from
the screenshot here you can see the top right door uses all mining
access for some unknown reason, i'm assuming that this was simply
forgotten in a rework of the department so i'm fixing it as it was shown
to me in a dream (a cargo player told me it irritated them and others).

![Screenshot 2024-01-29
162437](https://github.com/tgstation/tgstation/assets/120208006/e02278a1-1d44-406a-8ded-07de9040fd68)

i also went ahead and replaced the door it used to also use the mail
sorting room door that the top uses, as it was originally using the
mining decontamination room door, which is another reason i was thinkin'
it got reworked and overlooked, as the decontamination rooms just four
tiles above it and uses high security doors.

the actual access changes made were that i removed the all/supply/mining
access required on the door and gave it any/supply/general, mining, and
bitden, along with replacing the top doors access with
any/supply/general, mining, and bitden access so people who get
jobchanged into a cargo job have an easier time actually getting in in
case the HoP forgets, i factchecked this with delta and a couple of
other maps, which split the idea because delta does what i'm doing, but
maps like meta and icebox use all/supply/general and nothing else, so if
anyone has any problems with this i can change it to all/supply/general,
i just view this as a safer bet for people who might get jobchanged by
the HoP whos playing clash royale while filing ID accesses.

## Why It's Good For The Game

i don't see a point to having two separate doors for the same room to
have different access restrictions when both doors also come from the
same room, plus the door being named mining decontamination when it
doesn't lead into mining decontamination anymore irks me now that i saw
it and it must be changed or else i will weep. the access changes for
the doors allows people who get jobchanges into the department an easier
time if for some reason they needed to keep access from their previous
job but can't fit everything, for instance a slow round for a psych who
wants to game but keep psych access.

## Changelog


:cl:

fix: the top and top righthand doors of northstars cargo mail sorting
room now use any supply general, mining, and bitden access, and the top
righthand door no longer says its mining decontamination and uses the
proper mail sorting room airlock instead.

/:cl:

* northstar mail sorting room access and door nitpick

---------

Co-authored-by: Donglesplonge <[email protected]>
ReezeBL pushed a commit that referenced this pull request Feb 6, 2024
…1777)

* northstar mail sorting room access and door nitpick (#81179)

## About The Pull Request

back from the grave for yet another minor access nitpick that was
brought to my attention.

northstars mail room had an awkward access woopsy attached to it, from
the screenshot here you can see the top right door uses all mining
access for some unknown reason, i'm assuming that this was simply
forgotten in a rework of the department so i'm fixing it as it was shown
to me in a dream (a cargo player told me it irritated them and others).

![Screenshot 2024-01-29
162437](https://github.com/tgstation/tgstation/assets/120208006/e02278a1-1d44-406a-8ded-07de9040fd68)

i also went ahead and replaced the door it used to also use the mail
sorting room door that the top uses, as it was originally using the
mining decontamination room door, which is another reason i was thinkin'
it got reworked and overlooked, as the decontamination rooms just four
tiles above it and uses high security doors.

the actual access changes made were that i removed the all/supply/mining
access required on the door and gave it any/supply/general, mining, and
bitden, along with replacing the top doors access with
any/supply/general, mining, and bitden access so people who get
jobchanged into a cargo job have an easier time actually getting in in
case the HoP forgets, i factchecked this with delta and a couple of
other maps, which split the idea because delta does what i'm doing, but
maps like meta and icebox use all/supply/general and nothing else, so if
anyone has any problems with this i can change it to all/supply/general,
i just view this as a safer bet for people who might get jobchanged by
the HoP whos playing clash royale while filing ID accesses.

## Why It's Good For The Game

i don't see a point to having two separate doors for the same room to
have different access restrictions when both doors also come from the
same room, plus the door being named mining decontamination when it
doesn't lead into mining decontamination anymore irks me now that i saw
it and it must be changed or else i will weep. the access changes for
the doors allows people who get jobchanges into the department an easier
time if for some reason they needed to keep access from their previous
job but can't fit everything, for instance a slow round for a psych who
wants to game but keep psych access.

## Changelog


:cl:

fix: the top and top righthand doors of northstars cargo mail sorting
room now use any supply general, mining, and bitden access, and the top
righthand door no longer says its mining decontamination and uses the
proper mail sorting room airlock instead.

/:cl:

* northstar mail sorting room access and door nitpick

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Donglesplonge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants