[MIRROR] Fixes material market prices going negative & runtime when buying materials #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uying materials [MDB IGNORE] (#25095) * Fixes material market prices going negative & runtime when buying materials (#79732) ## About The Pull Request - Fixes #79114 - Fixes #79245 The hope is that it should fix these 2 issues because looking at the math is seems solid. This PR ensures 2 things - If the current market price of a material is 0 then neither the market quantity nor its price is changed because the material is worthless at that point so adding more is just meaningless - Corrects the formulae to calculate the new price so we get the right rate of change For more details on how this bug occurs refer to tgstation/tgstation#79114 (comment) Mentioning @ Iajret in the changelog cause credits(no pun intended) goes to them for discovering said bug This also corrects a runtime that went unresolved in - #79307 I could not get my code suggestion there in time so i'm just carrying it over here ## Changelog SyncIt21, Iajret :cl: fix: selling large amount of mats in cargo should not give you infinite credits fix: runtime when adjusting material market after buying /:cl: * Fixes material market prices going negative & runtime when buying materials --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25095
Original PR: tgstation/tgstation#79732
About The Pull Request
The hope is that it should fix these 2 issues because looking at the math is seems solid. This PR ensures 2 things
For more details on how this bug occurs refer to tgstation/tgstation#79114 (comment)
Mentioning @ Iajret in the changelog cause credits(no pun intended) goes to them for discovering said bug
This also corrects a runtime that went unresolved in
I could not get my code suggestion there in time so i'm just carrying it over here
Changelog
🆑 SyncIt21, Iajret
fix: selling large amount of mats in cargo should not give you infinite credits
fix: runtime when adjusting material market after buying
/:cl: