Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes chat bluescreen #702

Merged
merged 1 commit into from
Nov 19, 2023
Merged

[MIRROR] Fixes chat bluescreen #702

merged 1 commit into from
Nov 19, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25099
Original PR: tgstation/tgstation#79821

About The Pull Request

Adds a chat reliability layer reliability layer

more info

json.parse claims another
d86

javascript completely opaque about what throws. innocuous function not wrapped in try/catch block

Why It's Good For The Game

No bluescreen?
Fixes #79814

Changelog

🆑 jlsnow301
fix: Chat shouldn't bluescreen at the start of the round
/:cl:

* Fixes chat bluescreen (#79821)

## About The Pull Request
Adds a chat reliability layer reliability layer

<details>
<summary>more info</summary>

json.parse claims another

![d86](https://github.com/tgstation/tgstation/assets/42397676/c7d864f2-b5d6-4c5d-95b4-deece37c808d)

javascript completely opaque about what throws. innocuous function not
wrapped in try/catch block

</details>

## Why It's Good For The Game
No bluescreen?
Fixes #79814
## Changelog
:cl:
fix: Chat shouldn't bluescreen at the start of the round
/:cl:

* Fixes chat bluescreen

---------

Co-authored-by: Jeremiah <[email protected]>
@Iajret Iajret enabled auto-merge (squash) November 19, 2023 08:46
@Iajret Iajret merged commit 80255ae into master Nov 19, 2023
24 checks passed
AnywayFarus added a commit that referenced this pull request Nov 19, 2023
@Iajret Iajret deleted the upstream-mirror-25099 branch November 19, 2023 09:24
Iajret pushed a commit that referenced this pull request Jan 31, 2024
* GAGS-based camo pants, for digi & normal legs.

* Refactors nonmodular edits out of pants & shorts

Also renames camo_shorts to camo_pants to stay in-line with its sprite name & appearance.

* Apply suggestions from code review

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
ReezeBL pushed a commit that referenced this pull request Feb 6, 2024
* GAGS-based camo pants, for digi & normal legs.

* Refactors nonmodular edits out of pants & shorts

Also renames camo_shorts to camo_pants to stay in-line with its sprite name & appearance.

* Apply suggestions from code review



---------

Co-authored-by: CliffracerX <[email protected]>
Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants