Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] CRAB-17 will round down the credit amount it steals #673

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25052
Original PR: tgstation/tgstation#79761

About The Pull Request

When stealing credits, the CRAB-17 takes a between 5 and 15 percent of your current credit balance.
Due to how numbers work, this almost always ends up with a fractional amount being taken (ie 10% of 1015 is 101.5)
There is, as far as I'm aware, no way to get rid of this fractional amount, as you can only pull whole credits from your ID.

Why It's Good For The Game

CRAB-17 will now take between 5 and 15 percent of your current credits, rounded down.
No more 1/3 of a credit to stare at in abject horror.

Changelog

🆑 Shadow-Quill
fix: The CRAB-17 will now only take whole credits, as fractional credits were found to be worth less.
🆑

…ORE] (#25052)

* CRAB-17 will round down the credit amount it steals (#79761)

## About The Pull Request

When stealing credits, the CRAB-17 takes a between 5 and 15 percent of
your current credit balance.
Due to how numbers work, this almost always ends up with a fractional
amount being taken (ie 10% of 1015 is 101.5)
There is, as far as I'm aware, no way to get rid of this fractional
amount, as you can only pull whole credits from your ID.

## Why It's Good For The Game

CRAB-17 will now take between 5 and 15 percent of your current credits,
rounded down.
No more 1/3 of a credit to stare at in abject horror.

## Changelog
:cl:
fix: The CRAB-17 will now only take whole credits, as fractional credits
were found to be worth less.
:cl:

* CRAB-17 will round down the credit amount it steals

---------

Co-authored-by: Shadow-Quill <[email protected]>
@Iajret Iajret merged commit 0d4de46 into master Nov 17, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25052 branch November 17, 2023 22:49
AnywayFarus added a commit that referenced this pull request Nov 17, 2023
Iajret pushed a commit that referenced this pull request Jan 29, 2024
* Respriting the goldfish and lanternfish (#81148)

## About The Pull Request
Those are two fishes I was too tired to resprite as well last time. I've
got to say their color schemes came out a bit more lively than the rest.

## Why It's Good For The Game

![immagine](https://github.com/tgstation/tgstation/assets/42542238/971d1171-317a-4ebc-903e-c9378c2065a2)

The pufferfish looks too cute as is so I couldn't bring myself to
resprite it.

## Changelog

:cl:
image: Resprited the goldfish and lanternfish as well.
/:cl:

* Respriting the goldfish and lanternfish

---------

Co-authored-by: Ghom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants