Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds the gifted "negative" quirk #666

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24967

About The Pull Request

JungleRat wanted a quirk that gave some freebie points. This perk, gifted, gives the player 6 free negative points to use on positive quirk points.

How This Contributes To The Skyrat Roleplay Experience

Ultimately this allows more player expression without taking debilitating quirks.

Proof of Testing

Changelog

🆑 TheSS13Melon
add: Adds a "negative" perk called gifted which gives 6 free points.
/:cl:

* Gifted

Adds the gifted quirk.

* Update tgstation.dme

* updates

* Update code/_globalvars/traits.dm

* updoot

* Update traits.dm

* Update code/__DEFINES/~skyrat_defines/traits.dm

* Update modular_skyrat/master_files/code/datums/quirks/negative.dm

---------

Co-authored-by: Bloop <[email protected]>
@Iajret Iajret merged commit 4f79c0f into master Nov 20, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-24967 branch November 20, 2023 14:11
AnywayFarus added a commit that referenced this pull request Nov 20, 2023
Iajret pushed a commit that referenced this pull request Jan 28, 2024
* Sets reagent holder minimum volume to 0.01 (#81131)

## About The Pull Request
- Fixes #81096

Basically if the reagent volume inside an reagent holder falls below
`CHEMICAL_VOLUME_ROUNDING`(or 0.01) only then is it garbage collected.
Helps with small transfer rates like the plumbing iv drip

This means volumes like 0.01 of a reagent can now exist inside your
beaker, previously this was 0.05

## Changelog
:cl:
fix: sets minimum volume of reagent allowed to exist inside anything to
0.01 therefore allowing plumbing iv drip small transfer rates to occur
without reagents disappearing.
/:cl:

* Sets reagent holder minimum volume to 0.01

---------

Co-authored-by: SyncIt21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants